Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default pointing device driver. #16190

Merged
merged 3 commits into from
Feb 5, 2022
Merged

Remove default pointing device driver. #16190

merged 3 commits into from
Feb 5, 2022

Conversation

daskygit
Copy link
Member

@daskygit daskygit commented Feb 3, 2022 •
edited
Loading

Description

A typo like POINTING_DEIVCE_DRIVER = adns5050 now produces an error when compiling rather than using POINTING_DEVICE_DRIVER = custom.

I've included the required rules.mk changes, so keymaps/keyboards that were missing the rule still have the same behaviour as before this change.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Feb 3, 2022
@daskygit daskygit force-pushed the fix/remove_default_pointing_driver branch from 12c339e to 3a80fda Compare February 5, 2022 02:41
@daskygit daskygit marked this pull request as ready for review February 5, 2022 03:05
@daskygit daskygit changed the title Removing default pointing driver. Remove default pointing driver. Feb 5, 2022
@daskygit daskygit changed the title Remove default pointing driver. Remove default pointing device driver. Feb 5, 2022
@drashna drashna requested a review from a team February 5, 2022 03:24
@zvecr zvecr merged commit b1debfb into qmk:develop Feb 5, 2022
@daskygit daskygit deleted the fix/remove_default_pointing_driver branch March 13, 2022 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core documentation keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daskygit @drashna @fauxpark @zvecr